Aye I can't see any issues at a glance, testing shows increased stability. Would like to do as much testing as possible as there is always a chance that more Gremlins are telling

Squatnet commented

2019-06-18 10:54:18 +01:00

(Migrated from github.com)

On Tue, 18 Jun 2019, 10:50 kieran-boyle, notifications@github.com wrote:

@kieran-boyle approved this pull request.

Aye I can't see any issues at a glance, testing shows increased stability.
Would like to do as much testing as possible as there is always a chance
that more Gremlins are telling

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Squatnet/ArduinoStuff/pull/107?email_source=notifications&email_token=AGIIIGVSM2PKQQQVYC2N5LTP3CVVDA5CNFSM4HY2DYV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB322NMI#pullrequestreview-250980017,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGIIIGWVT4BFPB5WT7LOS7LP3CVVDANCNFSM4HY2DYVQ
.

I'm working today but ig you are heading round feel free to test it. I'm aware of a few issues with app registration so am not worried about it that for now. would like to.know if the wiznet works just as well on the uno as it does on the mega. Ideally it should work fine as it was software issue and not buffer overrun On Tue, 18 Jun 2019, 10:50 kieran-boyle, <notifications@github.com> wrote: > *@kieran-boyle* approved this pull request. > > Aye I can't see any issues at a glance, testing shows increased stability. > Would like to do as much testing as possible as there is always a chance > that more Gremlins are telling > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/Squatnet/ArduinoStuff/pull/107?email_source=notifications&email_token=AGIIIGVSM2PKQQQVYC2N5LTP3CVVDA5CNFSM4HY2DYV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB322NMI#pullrequestreview-250980017>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AGIIIGWVT4BFPB5WT7LOS7LP3CVVDANCNFSM4HY2DYVQ> > . >

kieran-boyle commented

2019-06-18 10:57:08 +01:00

(Migrated from github.com)

Aye I don't see any reason for there to be issues with the Uno. It is possible that there are unseen bugs in fastLED code even. Everything needs as much testing as possible. I'll plug her in again later and see if anything jumps at me eh.

Squatnet commented

2019-06-18 11:00:25 +01:00

(Migrated from github.com)

Aye. Test for recurrence of any open issues. Close as tested.

On Tue, 18 Jun 2019, 10:57 kieran-boyle, notifications@github.com wrote:

Aye I don't see any reason for there to be issues with the Uno. It is
possible that there are unseen bugs in fastLED code even. Everything needs
as much testing as possible. I'll plug her in again later and see if
anything jumps at me eh.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Squatnet/ArduinoStuff/pull/107?email_source=notifications&email_token=AGIIIGQXNL2DF2PN7NRAMHTP3CWPLA5CNFSM4HY2DYV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX53O3Y#issuecomment-503035759,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGIIIGUGQFLGQ527ZVTTE2TP3CWPLANCNFSM4HY2DYVQ
.

Aye. Test for recurrence of any open issues. Close as tested. On Tue, 18 Jun 2019, 10:57 kieran-boyle, <notifications@github.com> wrote: > Aye I don't see any reason for there to be issues with the Uno. It is > possible that there are unseen bugs in fastLED code even. Everything needs > as much testing as possible. I'll plug her in again later and see if > anything jumps at me eh. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/Squatnet/ArduinoStuff/pull/107?email_source=notifications&email_token=AGIIIGQXNL2DF2PN7NRAMHTP3CWPLA5CNFSM4HY2DYV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX53O3Y#issuecomment-503035759>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AGIIIGUGQFLGQ527ZVTTE2TP3CWPLANCNFSM4HY2DYVQ> > . >