New Master Branch #88

Merged

Riolaurenti merged 3 commits from development into master

2019-05-14 19:10:55 +01:00

Riolaurenti commented

2019-05-12 11:34:55 +01:00

(Migrated from github.com)

Old Master Branch outdated by DV2 working.

Most files have been replaced/deleted in this pull request.

Quick search over the existing branches for anything I might have missed that is of any importance, then delete the lot.

Old Master Branch outdated by DV2 working. Most files have been replaced/deleted in this pull request. Quick search over the existing branches for anything I might have missed that is of any importance, then delete the lot.

Squatnet (Migrated from github.com) reviewed

2019-05-12 13:51:34 +01:00

Squatnet (Migrated from github.com) left a comment

I'm not 100% following what you mean by

The BPM clock counter will be the new MODE option, with patterns and colour choices the only changes available on iteration.
The next master will be left otherwise, so to have a working demonstration.
Switch code would need to be adapted to accept integers, as well as changes to the application and parser.

I feel rather than just straight up deleted all the old stuff we should keep it somewhere. Maybe even a different repository, for reference purposes for future projects.

I'm not 100% following what you mean by > The BPM clock counter will be the new MODE option, with patterns and colour choices the only changes available on iteration. > The next master will be left otherwise, so to have a working demonstration. > Switch code would need to be adapted to accept integers, as well as changes to the application and parser. I feel rather than just straight up deleted all the old stuff we should keep it somewhere. Maybe even a different repository, for reference purposes for future projects.

Riolaurenti commented

2019-05-12 15:01:15 +01:00

(Migrated from github.com)

Sorry should have been clearer.

The MODE should only switch between bpm or internal timers.
doubt a mode needs to exist at all for that to happen.

Yes do as you feel fit, I couldn't find the best way to keep all detailled changes from eg the DV2 work branch and other branches together.
If deleted, are they archived or removed?

Sorry should have been clearer. The MODE should only switch between bpm or internal timers. doubt a mode needs to exist at all for that to happen. Yes do as you feel fit, I couldn't find the best way to keep all detailled changes from eg the DV2 work branch and other branches together. If deleted, are they archived or removed?