squatnet/ArduinoStuff
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fast led rainbow fix #94

Merged
Squatnet merged 4 commits from FastLedRainbowFix into FastLedi2c 2019-05-28 21:33:26 +01:00
Conversation 13 Commits 4 Files changed 1 +17 -13
Squatnet commented 2019-05-28 21:33:11 +01:00 (Migrated from github.com)
Copy link

Fixes the rainbow. Pallete mode issue persists for now

Fixes the rainbow. Pallete mode issue persists for now
kieran-boyle (Migrated from github.com) reviewed 2019-05-28 21:33:11 +01:00
kieran-boyle commented 2019-05-28 23:04:16 +01:00 (Migrated from github.com)
Copy link

interesting, i am surprised this caused an issue, any idea why that would be the case?

interesting, i am surprised this caused an issue, any idea why that would be the case?
Squatnet (Migrated from github.com) reviewed 2019-05-28 23:11:17 +01:00
2.aNCS_LED_DV2/current/I2CtoFastLEDs/I2CtoFastLEDs.ino
Squatnet (Migrated from github.com) commented 2019-05-28 23:11:17 +01:00
Copy link

Fix rainbow by adding gHue back in

Fix rainbow by adding gHue back in
Squatnet (Migrated from github.com) reviewed 2019-05-28 23:11:34 +01:00
2.aNCS_LED_DV2/current/I2CtoFastLEDs/I2CtoFastLEDs.ino
@ -49,3 +49,3 @@
TBlendType currentBlending;//blending type
uint8_t gHue = 0;
String string = ""; //holder for the parser string.
Squatnet (Migrated from github.com) commented 2019-05-28 23:11:34 +01:00
Copy link

Fix rainbow by adding gHue back in

Fix rainbow by adding gHue back in
Squatnet (Migrated from github.com) reviewed 2019-05-28 23:13:31 +01:00
2.aNCS_LED_DV2/current/I2CtoFastLEDs/I2CtoFastLEDs.ino
Squatnet (Migrated from github.com) commented 2019-05-28 23:13:31 +01:00
Copy link

Fix rainbow in palette mode by adding gHue and using fill_palette instead of changing the color of each led based on a fixed start with color from palette

Fix rainbow in palette mode by adding gHue and using fill_palette instead of changing the color of each led based on a fixed start with color from palette
Squatnet (Migrated from github.com) reviewed 2019-05-28 23:14:24 +01:00
2.aNCS_LED_DV2/current/I2CtoFastLEDs/I2CtoFastLEDs.ino
Squatnet (Migrated from github.com) commented 2019-05-28 23:14:24 +01:00
Copy link

Increment gHue to make rainbow and palette index scroll

Increment gHue to make rainbow and palette index scroll
Squatnet (Migrated from github.com) reviewed 2019-05-28 23:16:40 +01:00
2.aNCS_LED_DV2/current/I2CtoFastLEDs/I2CtoFastLEDs.ino
Squatnet (Migrated from github.com) commented 2019-05-28 23:16:40 +01:00
Copy link

When we set these values in the parser we specifically cast the values toInt() it makes sense to store them as int too. The memory saving is Negligible

When we set these values in the parser we specifically cast the values toInt() it makes sense to store them as int too. The memory saving is Negligible
Squatnet (Migrated from github.com) reviewed 2019-05-28 23:19:16 +01:00
2.aNCS_LED_DV2/current/I2CtoFastLEDs/I2CtoFastLEDs.ino
Squatnet (Migrated from github.com) commented 2019-05-28 23:19:16 +01:00
Copy link

Changed deltaindex value to make more colours from the palette show at once.

Changed deltaindex value to make more colours from the palette show at once.
Squatnet (Migrated from github.com) reviewed 2019-05-28 23:20:22 +01:00
2.aNCS_LED_DV2/current/I2CtoFastLEDs/I2CtoFastLEDs.ino
Squatnet (Migrated from github.com) commented 2019-05-28 23:20:21 +01:00
Copy link

This is active code. It's literally there in an if statement in loop

This is active code. It's literally there in an if statement in loop
Squatnet (Migrated from github.com) reviewed 2019-05-28 23:21:12 +01:00
2.aNCS_LED_DV2/current/I2CtoFastLEDs/I2CtoFastLEDs.ino
@ -62,3 +62,4 @@
int numberOfPalettes=18;//total number of palettes available -1.
int colorIndex = 0;//holds the position in the palette array for the color to show.
int LEDStart = 0;//this holds the number of the first LED in the arry to start printing a pattern to.
int LEDEnd = 0;//this holds the number of the last LED in the arry to start printing a pattern to.
Squatnet (Migrated from github.com) commented 2019-05-28 23:21:12 +01:00
Copy link

Same here we cast to an int in parser so why not save any possible messing about with different data types and just keep it all as int.

Same here we cast to an int in parser so why not save any possible messing about with different data types and just keep it all as int.
Squatnet commented 2019-05-28 23:23:21 +01:00 (Migrated from github.com)
Copy link

@kieran-boyle see above.

@kieran-boyle see above.
Riolaurenti commented 2019-05-29 10:53:06 +01:00 (Migrated from github.com)
Copy link

check fastLED.io - rainbow.
No gHue, no colour prog..

On Tue, May 28, 2019 at 11:04 PM kieran-boyle notifications@github.com
wrote:

interesting, i am surprised this caused an issue, any idea why that would
be the case?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Squatnet/ArduinoStuff/pull/94?email_source=notifications&email_token=AFPE5K5EH7CMK6UE6CHDMP3PXWT6DA5CNFSM4HQG3RE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWNSNOA#issuecomment-496707256,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFPE5K7AR7TJEBJ2SN7G7PDPXWT6DANCNFSM4HQG3REQ
.

check fastLED.io - rainbow. No gHue, no colour prog.. On Tue, May 28, 2019 at 11:04 PM kieran-boyle <notifications@github.com> wrote: > interesting, i am surprised this caused an issue, any idea why that would > be the case? > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/Squatnet/ArduinoStuff/pull/94?email_source=notifications&email_token=AFPE5K5EH7CMK6UE6CHDMP3PXWT6DA5CNFSM4HQG3RE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWNSNOA#issuecomment-496707256>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AFPE5K7AR7TJEBJ2SN7G7PDPXWT6DANCNFSM4HQG3REQ> > . >
Squatnet commented 2019-05-29 13:13:01 +01:00 (Migrated from github.com)
Copy link

That's exactly it. You guys like the way I've commented the changes in
review? Think this is the way to do the reviews on pull requests now..
makes it a lot easier to see not just what has changed but also why it has
changed.

On Wed, 29 May 2019, 10:53 Riiio, notifications@github.com wrote:

check fastLED.io - rainbow.
No gHue, no colour prog..

On Tue, May 28, 2019 at 11:04 PM kieran-boyle notifications@github.com
wrote:

interesting, i am surprised this caused an issue, any idea why that would
be the case?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<
https://github.com/Squatnet/ArduinoStuff/pull/94?email_source=notifications&email_token=AFPE5K5EH7CMK6UE6CHDMP3PXWT6DA5CNFSM4HQG3RE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWNSNOA#issuecomment-496707256
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AFPE5K7AR7TJEBJ2SN7G7PDPXWT6DANCNFSM4HQG3REQ

.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/Squatnet/ArduinoStuff/pull/94?email_source=notifications&email_token=AGIIIGXU47BR7GFAX5ANWK3PXZHAFA5CNFSM4HQG3RE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWOZYJA#issuecomment-496868388,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGIIIGTOQMCCIBO23KRWH53PXZHAFANCNFSM4HQG3REQ
.

That's exactly it. You guys like the way I've commented the changes in review? Think this is the way to do the reviews on pull requests now.. makes it a lot easier to see not just what has changed but also why it has changed. On Wed, 29 May 2019, 10:53 Riiio, <notifications@github.com> wrote: > check fastLED.io - rainbow. > No gHue, no colour prog.. > > On Tue, May 28, 2019 at 11:04 PM kieran-boyle <notifications@github.com> > wrote: > > > interesting, i am surprised this caused an issue, any idea why that would > > be the case? > > > > — > > You are receiving this because you are subscribed to this thread. > > Reply to this email directly, view it on GitHub > > < > https://github.com/Squatnet/ArduinoStuff/pull/94?email_source=notifications&email_token=AFPE5K5EH7CMK6UE6CHDMP3PXWT6DA5CNFSM4HQG3RE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWNSNOA#issuecomment-496707256 > >, > > or mute the thread > > < > https://github.com/notifications/unsubscribe-auth/AFPE5K7AR7TJEBJ2SN7G7PDPXWT6DANCNFSM4HQG3REQ > > > > . > > > > — > You are receiving this because you modified the open/close state. > Reply to this email directly, view it on GitHub > <https://github.com/Squatnet/ArduinoStuff/pull/94?email_source=notifications&email_token=AGIIIGXU47BR7GFAX5ANWK3PXZHAFA5CNFSM4HQG3RE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWOZYJA#issuecomment-496868388>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AGIIIGTOQMCCIBO23KRWH53PXZHAFANCNFSM4HQG3REQ> > . >
Sign in to join this conversation.
Reviewers
No reviewers
kieran-boyle
Labels
Clear labels   
Core

   
Fixed

   
Godot

   
HardwareIssue

   
LEDS

   
Networking

   
Problem

   
SoftwareIssue

   
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
on hold

   
question
Further information is requested

  
reminder

   
todo 🗒️

   
wontfix
This will not be worked on

No labels
Core
Fixed
Godot
HardwareIssue
LEDS
Networking
Problem
SoftwareIssue
duplicate
enhancement
good first issue
help wanted
invalid
on hold
question
reminder
todo 🗒️
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
squatnet/ArduinoStuff!94
No description provided.